This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
fix: convert output of multihash.decode to buffer #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multihash module returns Uint8Arrays from it's decode method but smart-buffer requires everything to be a buffer so convert the output.
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 84.90% 84.96% +0.05%
==========================================
Files 8 8
Lines 265 266 +1
==========================================
+ Hits 225 226 +1
Misses 40 40
Continue to review full report at Codecov.
|
vmx
approved these changes
Aug 5, 2020
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multihash module returns Uint8Arrays from it's decode method but
smart-buffer requires everything to be a buffer so convert the output.